Stream: git-wasmtime

Topic: wasmtime / issue #6935 Include Wasm-defined globals and m...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2023 at 21:59):

fitzgen commented on issue #6935:

Alright this is ready for review now! @alexcrichton mind taking a look?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2023 at 19:30):

fitzgen commented on issue #6935:

One thing I'm missing though, how will this all fit together? While we can dump globals/memories/etc that happen to be in the Store how is it planned to correlate that back to indices within module instances?

Put another way this gives access to private memories/globals which seems required to have core dumps at all, but beyond providing access it doens't provide a great means of figuring out what a Global or a Memory is

I have a WIP follow up PR that actually makes wasmtime::CoreDump serializable (we don't actually use wasmtime::CoreDump yet for the -Dcoredump=... flag, for example) and will do all the mapping between frames and instances and modules and globals and memories. There is definitely more to be done here, and you shouldn't expect core dump stuff to be finished and complete after this PR.

Last updated: Oct 23 2024 at 20:03 UTC