Stream: git-wasmtime

Topic: wasmtime / issue #6922 riscv64: Refactor `Inst::generate_...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 12:03):

afonso360 opened issue #6922:

:wave: Hey,

This is a followup from a comment from @jameysharp in 6915. Inst::generate_imm tries to match a 64 bit constant into a pair of Imm20 and Imm12's so that we can generate that immediate from a pair of instructions.

The current logic is quite complex and somewhat unreadable, but it doesn't need to be. @jameysharp's version is a lot cleaner, and i suspect is just missing a small fix for a few edge cases. We should clean it up.

This function should be able to generate all 32 bit constants, as well as a good number of 64 bit constants.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 12:03):

afonso360 added the cranelift:area:riscv64 label to Issue #6922.

Last updated: Nov 22 2024 at 16:03 UTC