Stream: git-wasmtime

Topic: wasmtime / issue #6913 Remove component union types


view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 15:45):

lann commented on issue #6913:

Assuming it also gets merged, the first commit here should be refactored to use vhttps://github.com/bytecodealliance/wasm-tools/pull/1182

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 16:02):

lann edited a comment on issue #6913:

Assuming it also gets merged, the first commit here should be refactored to use https://github.com/bytecodealliance/wasm-tools/pull/1182

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 18:44):

github-actions[bot] commented on issue #6913:

Subscribe to Label Action

cc @fitzgen, @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 20:56):

lann commented on issue #6913:

I just pushed an update here anticipating a wit-bindgen 0.11.0 release. Obviously CI failed, but someone with access can hopefully just retrigger the CI jobs after that release and this should then be mergeable.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 20:59):

lann edited a comment on issue #6913:

I just pushed an update here anticipating a wit-bindgen 0.11.0 release. Obviously CI failed, but someone with access can hopefully just retrigger the CI jobs after that release and this should then be mergeable.

The previous CI run against wit-bindgen main passed: https://github.com/bytecodealliance/wasmtime/actions/runs/5979833964

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 21:35):

alexcrichton commented on issue #6913:

At this rate I think I'll post a bump for 0.11.0 on Monday, but it'll definitely include this

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 21:37):

alexcrichton commented on issue #6913:

Oh oops wrong project, I see now! I think it's ok to avoid a wit-bindgen update here as that's mainly used for tests. The dependency between wit-bindgen and wasmtime mainly goes the other direction where wit-bindgen relies on wasmtime for tests, but it's ok in this regard for them to be slightly out of sync.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 21:54):

lann commented on issue #6913:

Ah yeah I didn't really think that through. Well I'll fix it up when I get a chance if someone else doesnt get to it.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2023 at 15:13):

lann commented on issue #6913:

This should be ready now.


Last updated: Dec 23 2024 at 12:05 UTC