Stream: git-wasmtime

Topic: wasmtime / issue #6889 Is it possible to release a patch ...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 09:05):

TimonPost opened issue #6889:

On the 7th of August https://github.com/bytecodealliance/wasmtime/pull/6804 was merged which gives us quite some improvement in module compilation times. As it was merged with the main 2 days after the 0.12 branch was created (the 5th) it hasn't been released. Is it possible to release a patch 0.12.1 with this commit? Also, this means the RELEASES https://github.com/bytecodealliance/wasmtime/pull/6838 is not correct as this change was not included in 0.12.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 09:05):

TimonPost edited issue #6889:

On the 7th of August https://github.com/bytecodealliance/wasmtime/pull/6804 was merged which gives us quite some improvement in module compilation times. As it was merged with the main 2 days after the 0.12 branch was created (the 5th) it hasn't been released. Is it possible to release a patch 0.12.1 with this commit? Also, this means the RELEASES https://github.com/bytecodealliance/wasmtime/pull/6838 is not correct as this change was not included in 0.12.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 09:06):

TimonPost edited issue #6889:

On the 7th of August https://github.com/bytecodealliance/wasmtime/pull/6804 was merged which gives us quite some improvement in module compilation times. We hoped to get this feature in 0.12 but as it was merged with main 2 days after the 0.12 branch was created (the 5th) it hasn't been released. Is it possible to release a patch 0.12.1 with this commit? Also, this means the RELEASES https://github.com/bytecodealliance/wasmtime/pull/6838 is not correct as this change was not included in 0.12.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 09:07):

TimonPost edited issue #6889:

On the 7th of August https://github.com/bytecodealliance/wasmtime/pull/6804 was merged which gives us quite some improvement in module compilation times. We hoped to get this feature in 0.12 but as it was merged with main 2 days after the 0.12 branch was created (the 5th) it hasn't been released. Is it possible to release a patch 0.12.1 with this commit? Also, this means the RELEASES https://github.com/bytecodealliance/wasmtime/pull/6838 is not correct as this change was not included in 0.12.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 09:08):

TimonPost edited issue #6889:

On the 7th of August https://github.com/bytecodealliance/wasmtime/pull/6804 was merged which gives us quite some improvement in module compilation times. We hoped to get this feature in 0.12 but as it was merged with main 2 days after the 12.0 branch was created (the 5th) it hasn't been released. Is it possible to release a patch 12.1 with this commit? Also, this means the RELEASES https://github.com/bytecodealliance/wasmtime/pull/6838 is not correct as this change was not included in 12.0

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 09:08):

TimonPost edited issue #6889:

On the 7th of August https://github.com/bytecodealliance/wasmtime/pull/6804 was merged which gives us quite some improvement in module compilation times. We hoped to get this feature in 0.12 but as it was merged with main 2 days after the 12.0 branch was created (the 5th) it hasn't been released. Is it possible to release a patch 12.0.1 with this commit? Also, this means the RELEASES https://github.com/bytecodealliance/wasmtime/pull/6838 is not correct as this change was not included in 12.0

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 19:45):

alexcrichton commented on issue #6889:

Personally I think this is fine to do at this time. Would you be up for sending a PR to backport that change to the 12.0.0 release branch?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 14:22):

alexcrichton commented on issue #6889:

Done now via https://github.com/bytecodealliance/wasmtime/pull/6897 and https://github.com/bytecodealliance/wasmtime/pull/6901, so closing.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2023 at 14:22):

alexcrichton closed issue #6889:

On the 7th of August https://github.com/bytecodealliance/wasmtime/pull/6804 was merged which gives us quite some improvement in module compilation times. We hoped to get this feature in 0.12 but as it was merged with main 2 days after the 12.0 branch was created (the 5th) it hasn't been released. Is it possible to release a patch 12.0.1 with this commit? Also, this means the RELEASES https://github.com/bytecodealliance/wasmtime/pull/6838 is not correct as this change was not included in 12.0


Last updated: Dec 23 2024 at 13:07 UTC