Stream: git-wasmtime

Topic: wasmtime / issue #6886 Host resources wit-bindgen code ge...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2023 at 23:45):

github-actions[bot] commented on issue #6886:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 16:27):

alexcrichton commented on issue #6886:

Ok I've worked on this a bit this morning and I've pushed up https://github.com/Nor2-io/wasmtime/pull/1 which contains another round of comments for me (and some fixes for the deny/vet-related things I think). As I mentioned over there I'm happy to go through anything if you'd like clarifications or explanations!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2023 at 21:39):

alexcrichton commented on issue #6886:

One more round of changes at https://github.com/Nor2-io/wasmtime/pull/2 (again happy to go through anything if you'd like), and then I think this is good to go :+1:

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2023 at 14:27):

alexcrichton commented on issue #6886:

Also @silesmo would you be up for filing an issue for follow-up work?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2023 at 20:35):

silesmo commented on issue #6886:

Also @silesmo would you be up for filing an issue for follow-up work?

Yes I can do that! :smile:

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2023 at 18:39):

alexcrichton commented on issue #6886:

Pat's busy with streams and such so he'll take a look at this after-the-fact, so I'm going to go ahead and flag this for merge. Thanks again @silesmo!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2023 at 18:40):

alexcrichton commented on issue #6886:

oh I think this may need a rebase for merging now?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2023 at 02:50):

silesmo commented on issue #6886:

oh I think this may need a rebase for merging now?

I merged the latest changes now

Last updated: Nov 22 2024 at 17:03 UTC