Stream: git-wasmtime

Topic: wasmtime / issue #6878 feat(wasmtime-cli): restore suppor...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2023 at 22:12):

eduardomourar commented on issue #6878:

@pchickey and @elliottt, this is ready to be reviewed.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 16:44):

pchickey commented on issue #6878:

Looks like there is some sort of cargo issue that happens when building the cli, which doesnt happen in the usual set of tests that runs before the merge queue runs the full set. Put the string prtest:full in a commit message to get the full test suite running each time you push.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 20:55):

eduardomourar commented on issue #6878:

@pchickey, now tests are passing. I had to ignore the wasi-http tests on Windows as there were failing. I plan on further debugging those after PR #6877 lands.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 21:20):

eduardomourar edited a comment on issue #6878:

@pchickey, now tests are passing. I had to ignore the wasi-http tests on Windows as there were failing. Can we merge this, please? I plan on further debugging those after PR #6877 lands.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 06 2023 at 21:38):

eduardomourar edited a comment on issue #6878:

@pchickey, now tests are passing. I had to ignore the wasi-http tests on Windows as they were failing. Can we merge this, please? I plan on further debugging those after PR #6877 lands.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 06 2023 at 21:39):

eduardomourar commented on issue #6878:

@alexcrichton and @pchickey, could wasi-http be enabled back in the wasmtime v13 release branch, please? Otherwise, there will be no release with module support for this.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 06 2023 at 21:48):

alexcrichton commented on issue #6878:

AFAIK that was the plan yeah, so seems reasonable to me. The process for doing so would require a PR to the release-13.0.0 branch of Wasmtime. @eduardomourar are you ok doing that?


Last updated: Dec 23 2024 at 12:05 UTC