Stream: git-wasmtime

Topic: wasmtime / issue #6878 feat(wasmtime-cli): add flag for a...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2023 at 14:24):

alexcrichton commented on issue #6878:

Thanks! Could you expand a bit more on the rationale for this? Why would users of the CLI want to control async-vs-not? Or is this instead intended for testing the async implementations on the CLI?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2023 at 14:47):

eduardomourar commented on issue #6878:

Thanks! Could you expand a bit more on the rationale for this? Why would users of the CLI want to control async-vs-not? Or is this instead intended for testing the async implementations on the CLI?

Just added more details to the PR body itself.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2023 at 16:50):

pchickey commented on issue #6878:

This isn't the correct approach - instead, wasmtime-wasi::preview2::in_tokio should be made pub, and and the wasmtime-wasi-http crate should use that to implement a sync bindgen trait by wrapping the async bindgen trait.

futures::executor isnt the right executor to use with wasmtime-wasi, it will fall over if not used with tokio.

Last updated: Dec 23 2024 at 12:05 UTC