Wasmtime GitHub notifications bot (Aug 19 2023 at 05:24): Wasmtime GitHub notifications bot (Aug 19 2023 at 05:24):gurry commented on issue #6862:
I did not rename "inver(t|se)" at the some places like these:
https://github.com/bytecodealliance/wasmtime/blob/367bdc8c66df62d6854966a90564b42692a3f023/cranelift/codegen/src/isa/aarch64/inst/args.rs#L265because I felt if I renamed them I had to rename variables etc. upstream as well where these functions are called. Please let me know your thoughts on this.
More broadly speaking, "inverse" and its inflections are used quite extensively elsewhere. So does the change to "negate", although it is confined to condition codes, produce naming inconsistencies in the code base?
Wasmtime GitHub notifications bot (Aug 19 2023 at 05:24):gurry edited a comment on issue #6862:
I did not rename "inver(t|se)" at some places like these:
https://github.com/bytecodealliance/wasmtime/blob/367bdc8c66df62d6854966a90564b42692a3f023/cranelift/codegen/src/isa/aarch64/inst/args.rs#L265because I felt if I renamed them I had to rename variables etc. upstream as well where these functions are called. Please let me know your thoughts on that.
More broadly speaking, "inverse" and its inflections are used quite extensively elsewhere. So does the change to "negate", although it is confined to condition codes, produce naming inconsistencies in the code base?
Wasmtime GitHub notifications bot (Aug 19 2023 at 07:44):github-actions[bot] commented on issue #6862:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Nov 22 2024 at 17:03 UTC