Wasmtime GitHub notifications bot (Aug 18 2023 at 09:16): Wasmtime GitHub notifications bot (Aug 18 2023 at 09:16):gurry commented on issue #6858:
I wonder what tests we can write for this since any faulty input will be caught much before we reach the egraph pass by the earlier verifier invocations.
Wasmtime GitHub notifications bot (Aug 18 2023 at 10:21):afonso360 commented on issue #6858:
Huh, I'm not sure how we would test this. Maybe @jameysharp has an idea?
Wasmtime GitHub notifications bot (Aug 18 2023 at 16:01):jameysharp commented on issue #6858:
Yeah, I don't think we can write sensible tests for running the verifier after specific passes. It wouldn't be too hard to add an invalid egraph rule that only matches when some flag is set, and only turn that flag on in a test, but I don't think it's worth doing that.
Mostly I think we'll notice whether this is working whenever we write new incorrect egraph rules, which I'm sure will happen often enough. :sweat_smile:
Wasmtime GitHub notifications bot (Aug 19 2023 at 03:11):gurry commented on issue #6858:
That makes sense @jameysharp. Thanks.
Last updated: Nov 22 2024 at 17:03 UTC