Stream: git-wasmtime

Topic: wasmtime / issue #6833 Update stdio on Unix to fall back...

Wasmtime GitHub notifications bot (Aug 11 2023 at 00:36):

alexcrichton commented on issue #6833:

Sounds good to me :+1:

I've updated this to implement that instead. One concern I had about that approach is that historically in Rust I've been bitten about how the nonblocking flag affects the file description, not to be confused with the file descriptor. For example if many processes share the same stdout then if any of them set stdout to nonblocking then they all have a nonblocking stdout (which most are not prepared for). I'm a little concerned about Wasmtime here marking stdin as nonblocking since it could affect other components of the runtime too. I've confirmed locally though that at the very least pipe creates two file descriptions so it should be ok there.

I do still think there's a possibility for problems when Wasmtime is integrated with FFI for example, but I'm ok to wait for a bit and see if that crops up

Last updated: Oct 23 2024 at 20:03 UTC