Stream: git-wasmtime

Topic: wasmtime / issue #6756 isle: panic when rule for non-mult...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2023 at 23:30):

meithecatte opened issue #6756:

Consider the following code:

(type u64 (primitive u64))
(decl multi meow (u64) u64)
(extern extractor meow meow)
;; Note: not `multi nyaa`
(decl nyaa (u64) u64)
(rule (nyaa (meow x)) x)

This makes islec panic with the following message:

thread 'main' panicked at 'assertion failed: !block.steps.iter().any(|c| matches!(c.check, ControlFlow :: Loop { .. }))', cranelift/isle/isle/src/codegen.rs:421:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Not sure if that's the standard of error messages we hold islec to.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2023 at 17:09):

jameysharp commented on issue #6756:

Hah, whoops. That not only should have been caught in an earlier stage, but I left a TODO comment saying so:

https://github.com/bytecodealliance/wasmtime/blob/c9a9c2c1919858057ef51b91dc92216cf13ea477/cranelift/isle/isle/src/sema.rs#L2008

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2024 at 22:23):

jameysharp added the isle label to Issue #6756.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2024 at 22:23):

github-actions[bot] commented on issue #6756:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Dec 23 2024 at 13:07 UTC