Stream: git-wasmtime

Topic: wasmtime / issue #6736 Cap the maximum basic block paddin...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 17 2023 at 18:44):

github-actions[bot] commented on issue #6736:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "fuzzing"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 23:41):

cfallin commented on issue #6736:

Ah, yes, we actually do have 26-bit ranges that are relevant on AArch64: direct branches have a range of +/- 128MiB (2^26, times 4 because of PC alignment, signed). A function size up to 128MiB plus epsilon (144MiB, to pick a round number?) would I think give sufficient coverage.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 23:42):

cfallin commented on issue #6736:

(And x86-64 does have 2GiB ranges for all branches and RIP-relative labels, but we actually don't have façades to extend those; we just don't support a single function body that large!)

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2023 at 14:23):

alexcrichton commented on issue #6736:

Sounds reasonable! I've bumped the per-function limit to 150M and reduced the maximum number of functions to 5 to keep the overhead under 1G here


Last updated: Dec 23 2024 at 12:05 UTC