Wasmtime GitHub notifications bot (Jul 07 2023 at 15:16): Wasmtime GitHub notifications bot (Jul 07 2023 at 15:16):jameysharp commented on issue #6701:
Cool, thank you for this! There's no one "perfect" approach to profiling, so having more options on more platforms is great.
In case you weren't aware, I want to mention we recently merged a built-in profiler in Wasmtime that works on all platforms. It has some limitations, but in exchange, it doesn't require installing samply or perf or anything else.
It would be great if you could add some documentation for using samply with Wasmtime's perfmaps—especially if you can cover how to do it on macOS. See https://docs.wasmtime.dev/examples-profiling.html for the existing docs; the sources are in this repo in
docs/examples-profiling*.md.Even if Alex hadn't already merged this I was going to suggest that the documentation could be a separate PR, but now that it's merged it should definitely be a separate PR. :laughing:
Wasmtime GitHub notifications bot (Jul 07 2023 at 15:43):Maaarcocr commented on issue #6701:
Cool, thank you for this! There's no one "perfect" approach to profiling, so having more options on more platforms is great.
In case you weren't aware, I want to mention we recently merged a built-in profiler in Wasmtime that works on all platforms. It has some limitations, but in exchange, it doesn't require installing samply or perf or anything else.
It would be great if you could add some documentation for using samply with Wasmtime's perfmaps—especially if you can cover how to do it on macOS. See https://docs.wasmtime.dev/examples-profiling.html for the existing docs; the sources are in this repo in
docs/examples-profiling*.md.Even if Alex hadn't already merged this I was going to suggest that the documentation could be a separate PR, but now that it's merged it should definitely be a separate PR. :laughing:
yes I'm aware of the profiler, super cool work! (I also made a separate project that is very similar in https://github.com/Shopify/wasmprof)
my main use case for samply is profiling both native code (not running inside the wasm sandbox) and the wasm code, so the native wasmtime profiler (or wasmprof) do not work for me! (This is mostly because we embed wasmtime in a bigger application, so I'm interested in the whole system performance not just the code running in wasm)
And yes, I'll make a PR for docs too, thank you for the suggestion!
Wasmtime GitHub notifications bot (Jul 07 2023 at 15:50):Maaarcocr edited a comment on issue #6701:
Cool, thank you for this! There's no one "perfect" approach to profiling, so having more options on more platforms is great.
In case you weren't aware, I want to mention we recently merged a built-in profiler in Wasmtime that works on all platforms. It has some limitations, but in exchange, it doesn't require installing samply or perf or anything else.
It would be great if you could add some documentation for using samply with Wasmtime's perfmaps—especially if you can cover how to do it on macOS. See https://docs.wasmtime.dev/examples-profiling.html for the existing docs; the sources are in this repo in
docs/examples-profiling*.md.Even if Alex hadn't already merged this I was going to suggest that the documentation could be a separate PR, but now that it's merged it should definitely be a separate PR. :laughing:
yes I'm aware of the profiler, super cool work! (I also made a separate project that is very similar in https://github.com/Shopify/wasmprof)
my main use case for samply is profiling both native code (not running inside the wasm sandbox) and the wasm code, so the native wasmtime profiler (or wasmprof) does not work for me! (This is mostly because we embed wasmtime in a bigger application, so I'm interested in the whole system performance not just the code running in wasm)
And yes, I'll make a PR for docs too, thank you for the suggestion!
Last updated: Nov 22 2024 at 17:03 UTC