Stream: git-wasmtime

Topic: wasmtime / issue #6692 Fix a typo in an `unsafe impl Send...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2023 at 20:44):

github-actions[bot] commented on issue #6692:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2023 at 20:55):

alexcrichton commented on issue #6692:

Oh it was InstancePre<T> that depends on that impl. The previous impl though was unsafe impl<T> Send for InstancePre<T>, which led me to believe that these impls were still necessary.

That being said if I remove the impls InstancePre<T> is indeed Send/Sync as expected. My guess is that while this was historically necessary refactorings ended up making it not necessary!

I'll update this to remove the wrapper entirely

Last updated: Dec 23 2024 at 12:05 UTC