Wasmtime GitHub notifications bot (Jul 05 2023 at 20:44): Wasmtime GitHub notifications bot (Jul 05 2023 at 20:44):github-actions[bot] commented on issue #6691:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jul 06 2023 at 20:09):alexcrichton commented on issue #6691:
Ok I think this amounts for everything except
(borrow $T), fact,bindgen!, and documentation. Otherwise I think all the bits and pieces are there, or at least in basic form. I'm going to spend tomorrow trying to figure out how hardborrowwill be and then focus next week on docs, tests, and polish.
Wasmtime GitHub notifications bot (Jul 10 2023 at 20:45):github-actions[bot] commented on issue #6691:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jul 14 2023 at 17:00):alexcrichton commented on issue #6691:
Ok I believe that everything is now in place and this PR is ready to go. I've tagged @fitzgen for reviewing this, and I realize that it's a big ask at a whopping 7kloc change. I'm more than happy of course to pair-review together if you'd like.
As to the commit history currently the first commit is a bit of a monster, but all the subsequent commits should be a bit more bite-sized and easier to digest. That being said I wouldn't necessarily recommend closely following the history. I've gone back and forth over the history on representations and internals and nothing was ever documented until the end. That means there's a lot of transient state in the history which was removed or not really fully justified until the end. In that sense following the history may be difficult, so I'd recommend keeping that in mind if going commit-by-commit.
Wasmtime GitHub notifications bot (Jul 14 2023 at 17:02):alexcrichton commented on issue #6691:
I'll also point out that this is a huge design space embedding-API wise. I'm at least not personally aware of inspiration to draw upon, so I've basically staked out a random point in the design space that feels like a local-optimum-ish to me. I don't think this is bad, but I also don't think this is great. I'm sure that the embedding API will change over time as we get more experience with host embeddings, plumbing this through WASI, etc.
Wasmtime GitHub notifications bot (Jul 17 2023 at 21:59):fitzgen commented on issue #6691:
Taking a look.
Wasmtime GitHub notifications bot (Jul 21 2023 at 19:54):alexcrichton commented on issue #6691:
Thanks again for reviewing this @fitzgen, I know it was a big ask!
I'm gonna go ahead and queue this up for merging, and leave the newtype index for libcalls as a follow-up if that's ok, but otherwise I think I've addressed the other feedback you had
Last updated: Dec 23 2024 at 12:05 UTC