alexcrichton commented on issue #6606:
This ended up being a bit more complicated than I originally thought. Turns out that Cranelift previously didn't correctly implement the Windows fastcall calling convention with respect to vector arguments since they're all supposed to be indirect rather than immediate in registers (unlike System-V). That motivated me to remove the usage of
lower_pshufb
and the usage of a libcall, ending up in an SSE2 lowering fori8x16.popcnt
that's not the end of the world. I couldn't find a way to avoid the libcall forshuffle
orswizzle
, though, so I doubled down on fixing it. I've attempted to add the ABI bits here to get that working, but more eyes are of course always appreciated.
github-actions[bot] commented on issue #6606:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "cranelift:module", "cranelift:wasm", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Dec 23 2024 at 12:05 UTC