Stream: git-wasmtime

Topic: wasmtime / issue #6603 winch(x64): Add support for `loop`...

Wasmtime GitHub notifications bot (Jun 19 2023 at 13:44):

github-actions[bot] commented on issue #6603:

Subscribe to Label Action

cc @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "fuzzing", "winch"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing
• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 20 2023 at 15:16):

cfallin commented on issue #6603:

I decided to bundle these instructions together to be able to test more complex scenarios with loop, but I'm happy to split this change into two (or more).

That's totally fine; we'll have to review it anyway and IMHO when closely coupled it's better to see the pieces together. I'll try to get to this today!

Wasmtime GitHub notifications bot (Jun 20 2023 at 20:23):

saulecabrera commented on issue #6603:

@cfallin I've addressed all of your comments, I think this is ready for another pass. Regarding the visitor vs match-on-op discussion above, I've updated the approach to rely only on the visitor approach, by extending the existing validate_then_visit macro as suggested by @alexcrichton.

Wasmtime GitHub notifications bot (Jun 21 2023 at 01:14):

saulecabrera commented on issue #6603:

Seems that the Fuzz Targets step is having issues trying to fetch OCaml:

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/o/ocaml/ocaml-compiler-libs_4.13.1-3ubuntu1_amd64.deb  Error reading from server. Remote end closed connection [IP: 52.154.174.208 80]
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/o/ocaml/ocaml-interp_4.13.1-3ubuntu1_amd64.deb  Error reading from server. Remote end closed connection [IP: 52.154.174.208 80]
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/o/ocaml/ocaml_4.13.1-3ubuntu1_amd64.deb  Error reading from server. Remote end closed connection [IP: 52.154.174.208 80]

Wasmtime GitHub notifications bot (Jun 21 2023 at 10:24):

saulecabrera commented on issue #6603:

Seems to be fixed!

Last updated: Nov 22 2024 at 16:03 UTC