Stream: git-wasmtime

Topic: wasmtime / issue #6596 Add a `set_random` function to `Wa...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2023 at 16:34):

pchickey commented on issue #6596:

I don't think we should include _for_testing in the name nor #[cfg(test)] on the definition of this method. We need to trust that users of WasiCtxBuilder know what they are getting into.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2023 at 17:16):

sunfishcode commented on issue #6596:

I've now removed the _for_testing and the cfg(test), and added comments advising users of the hazards.

Last updated: Dec 23 2024 at 12:05 UTC