Stream: git-wasmtime

Topic: wasmtime / issue #6531 wip - add i32.popcnt and i64.popcn...

Wasmtime GitHub notifications bot (Jun 06 2023 at 21:45):

github-actions[bot] commented on issue #6531:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 09 2023 at 19:50):

itsrainy commented on issue #6531:

are you planning on providing a fallback implementation for popcnt if the has_popcnt flag is not enabled, similar to what Cranelift provides?

Yeah I can take a crack at that! I'll also add it to the fuzz targets

Wasmtime GitHub notifications bot (Jun 12 2023 at 23:09):

itsrainy commented on issue #6531:

@saulecabrera I added two popcnt fallbacks that I'd like help choosing between. popcount_fallback1 is a naive loop that is a bit more compact and easier to read (but ends up emitting more instructions). popcount_fallback2 is my attempt at implementing the fallback that is in cranelift.

Wasmtime GitHub notifications bot (Jun 13 2023 at 22:18):

itsrainy commented on issue #6531:

I moved the fallback logic up into the MacroAssembler. I was running into some tricky ownership issues when trying to pass the CodeGenContext into the Fn passed to unop, but I was able to implement the fallback only using the scratch register, so I don't think we actually need any more registers. I'd like to write some tests that actually use the fallback before this gets merged.

Last updated: Nov 22 2024 at 17:03 UTC