github-actions[bot] commented on issue #6531:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
itsrainy commented on issue #6531:
@saulecabrera I moved the register management bit to the MacroAssembler and added a couple of filetests for the fallback. I manually tested the fallback by forcing that branch in the code (just added an
!
to the has_popcnt check), and then runningcargo run --features=winch -- run --compiler winch --invoke "popcount" <module>
on this module with a bunch of different values:(module (func $popcount (result i64) i64.const 0xfffffffff0ffffff i64.popcnt ) (export "popcount" (func $popcount)) )
It seems to behave as intended! Let me know if there's anything else that needs cleaning up, otherwise I think this might be good to go!
Last updated: Dec 23 2024 at 13:07 UTC