Stream: git-wasmtime

Topic: wasmtime / issue #6514 refactor: Replace lazy-static with...

Wasmtime GitHub notifications bot (Jun 03 2023 at 11:14):

bjorn3 commented on issue #6514:

OnceLock has been stabilized in rust 1.70, but LazyLock hasn't yet.

Wasmtime GitHub notifications bot (Jun 03 2023 at 17:43):

howjmay commented on issue #6514:

@bjorn3 sorry let me open another PR for OneLock

Wasmtime GitHub notifications bot (Jun 06 2023 at 17:33):

jameysharp commented on issue #6514:

I think this is a great idea. I always love getting rid of dependencies.

But this is only stabilized in 1.70, right? We're having issues building Wasmtime with 1.70 for two of our target platforms (risc-v and s390). As far as I understand, the issues we've run into will be fixed by 1.71, so I don't think we're going to try to work around the 1.70 issues.

As a result, I would like to wait on merging this until 1.71 is out. But at that point I am interested in merging this! Please remind me to look at this again once that release is out.

Wasmtime GitHub notifications bot (Jun 10 2023 at 04:39):

howjmay commented on issue #6514:

@jameysharp this is great! Thanks!

Wasmtime GitHub notifications bot (Jul 17 2023 at 16:40):

alexcrichton commented on issue #6514:

@howjmay if you're up for it Rust 1.71.0 is now released and we've updated CI to use it, so if you're still up for rebasing this now'd be a prime time to do so

Wasmtime GitHub notifications bot (Jul 18 2023 at 18:12):

howjmay commented on issue #6514:

Hi @alexcrichton ! I have rebased my PR to the lasted commit on main, but it failed for unknown reason

Wasmtime GitHub notifications bot (Jul 18 2023 at 19:55):

alexcrichton commented on issue #6514:

It looks like you've accidentally changed a submodule here, and additionally this is using #![feature(lazy_cell)] which requires nightly but Wasmtime builds with stable so I don't think that will work as well unfortunately.

Wasmtime GitHub notifications bot (Aug 14 2023 at 12:56):

howjmay commented on issue #6514:

Let me wait for it becoming not nightly
thank you

Last updated: Dec 23 2024 at 12:05 UTC