Stream: git-wasmtime

Topic: wasmtime / issue #6480 Android release binaries

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 12:44):

martindevans commented on issue #6480:

Thanks for the feedback.

I just added prtest:full into the latest commit. Once that's finished I'll look into the other comments in more detail and then ping you :)

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 14:12):

martindevans commented on issue #6480:

From the look of the failure message:

Run ./.github/actions/binary-compatible-builds
unable to prepare context: path "/home/runner/work/wasmtime/wasmtime/ci/docker/aarch64-android" not found

It looks like there should be two new dockerfiles, x86_64-android and aarch64-android. I just want to check if that sounds right before I try to do that?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 15:25):

alexcrichton commented on issue #6480:

Ah yes non-Windows and non-macos builds currently all go through Docker. Given though that cargo ndk is being used here with GitHub Actions I think it's reasonable to skip docker for these builds. You can add some more special cases here to skip the CENTOS business for android builds.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 20:35):

martindevans commented on issue #6480:

Unfortunately I had to abandon this work. I don't know Rust build systems or GitHub actions very well, and this wasn't a good way to learn! :laughing:

Last updated: Nov 22 2024 at 17:03 UTC