Stream: git-wasmtime

Topic: wasmtime / issue #6468 winch: Aarch64 sub and mul

Wasmtime GitHub notifications bot (May 26 2023 at 16:32):

saulecabrera commented on issue #6468:

You mentioned fuzz testing being your main approach now. I wasn't sure how to do that, but would happily go run some if you can point me in the right direction.

Yeah, unfortunately you won't be able to get local fuzzing working for aarch64 working since it will at least require support for call, which we don't have yet. It shouldn't be to complex to get going though with all the recent work that we've done for supporting function calls and trampolines.

Wasmtime GitHub notifications bot (May 26 2023 at 16:33):

saulecabrera edited a comment on issue #6468:

You mentioned fuzz testing being your main approach now. I wasn't sure how to do that, but would happily go run some if you can point me in the right direction.

Yeah, unfortunately you won't be able to get local fuzzing working for aarch64 working since it will at least require support for call, which we don't have yet. It might not be too complex to get going though with all the recent work that we've done for supporting function calls and trampolines.

Wasmtime GitHub notifications bot (May 26 2023 at 16:34):

saulecabrera edited a comment on issue #6468:

You mentioned fuzz testing being your main approach now. I wasn't sure how to do that, but would happily go run some if you can point me in the right direction.

Yeah, unfortunately you won't be able to get local fuzzing working for aarch64 working since it will at least require support for call, which we don't have yet. It might not be too complex to get going though with all the recent work that we've done for supporting function calls and trampolines in x64.

Wasmtime GitHub notifications bot (May 26 2023 at 16:44):

github-actions[bot] commented on issue #6468:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (May 30 2023 at 18:29):

jimmyhmiller commented on issue #6468:

@saulecabrera Fixed. Sorry for the late responses on these. My notifications were still going to my old work email. Fixed now.

Wasmtime GitHub notifications bot (May 30 2023 at 19:22):

saulecabrera commented on issue #6468:

Thanks for the fixes! There's a failure in the updated sub tests for x64, because the output doesn't match (as expected), you should be able to fix that by running WINCH_TEST_BLESS=1 cargo run -- test inside the winch directory.

Wasmtime GitHub notifications bot (May 30 2023 at 20:35):

jimmyhmiller commented on issue #6468:

Yeah, sorry my bad. Totally thought I ran that a second time. Fixed now.

Last updated: Nov 22 2024 at 16:03 UTC