Stream: git-wasmtime

Topic: wasmtime / issue #6461 x64: Switch cranelift to output in...


view this post on Zulip Wasmtime GitHub notifications bot (May 26 2023 at 16:28):

alexcrichton commented on issue #6461:

As a very minor feature request: there's some trailing whitespace in the precise-output assertions, so while you're here if you see where that's coming from it might be nice to remove

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2023 at 23:11):

elliottt commented on issue #6461:

Well this ended up being quite a bit more of a yak shave than I was expecting: we don't currently plumb through enough information to make it easy to print the right size directive for amodes, so we often end up printing qword ptr with these changes when there's something more specific that capstone prints out. Fixing that would be quite a large refactor for a small payoff, so I'm going to close this PR but leave the branch up just in case anyone else decides to look into this in the future.


Last updated: Dec 23 2024 at 12:05 UTC