wasmtime / issue #6455 Function references unresolved issues · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / issue #6455 Function references unresolved issues

Wasmtime GitHub notifications bot (May 25 2023 at 11:40):

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[ ] Support for function references in the embedder API.

[ ] Failing tests:

[ ] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[ ] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[ ] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

Wasmtime GitHub notifications bot (May 26 2023 at 08:30):

dhil edited issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[ ] Support for function references in the embedder API.

[ ] Failing tests:

[ ] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[ ] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[ ] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Wasmtime GitHub notifications bot (May 26 2023 at 14:00):

alexcrichton labeled issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[ ] Support for function references in the embedder API.

[ ] Failing tests:

[ ] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[ ] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[ ] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Wasmtime GitHub notifications bot (Nov 02 2023 at 15:08):

dhil edited issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[ ] Support for function references in the embedder API.

[ ] Failing tests:

[ ] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[x] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[ ] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Wasmtime GitHub notifications bot (Feb 15 2024 at 00:31):

fitzgen commented on issue #6455:

I've finished support for function references over in https://github.com/bytecodealliance/wasmtime/pull/7943

Wasmtime GitHub notifications bot (Feb 20 2024 at 21:14):

fitzgen closed issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[ ] Support for function references in the embedder API.

[ ] Failing tests:

[ ] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[x] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[ ] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Wasmtime GitHub notifications bot (Feb 21 2024 at 10:13):

dhil edited issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[x] Support for function references in the embedder API.

[x] Failing tests:

[ ] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[x] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[ ] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Wasmtime GitHub notifications bot (Feb 21 2024 at 10:13):

dhil edited issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[x] Support for function references in the embedder API.

[x] Failing tests:

[ ] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[x] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[ ] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Wasmtime GitHub notifications bot (Feb 21 2024 at 10:13):

dhil edited issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[x] Support for function references in the embedder API.

[x] Failing tests:

[x] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[x] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[x] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Wasmtime GitHub notifications bot (Feb 21 2024 at 10:13):

dhil edited issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[x] Support for function references in the embedder API.

[x] Failing tests:

[x] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[x] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[x] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[ ] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Wasmtime GitHub notifications bot (Feb 21 2024 at 10:13):

dhil edited issue #6455:

PR #5288 implements the function references proposal modulo a few missing bits. The missing bits are:

[x] Support for function references in the embedder API.

[x] Failing tests:

[x] type-equivalence.wast: type canonicalisation is currently broken due to #[derive(hash)] not considering that two distinct typed function reference indices may point to structurally equivalent types.

[x] br_table.wast: this fails due to incomplete support for the various syntactic sugar in the wasm-tools/wast crate. See bytecodealliance/wasm-tools/pull/952.

[x] ref_null.wast and local_init.wast: fail due to lack of support in the embedder API.

[x] return_call_ref.wast, return_call_indirect.wast, and return_call.wast: fail due to lack of tail call support.

At the time of writing the implementation does not take advantage of the static non-null safety to elide null checks when executing call_ref: https://github.com/bytecodealliance/wasmtime/blob/36e9f7e577df11de14f5973308c4b4bd0565eed9/crates/cranelift/src/func_environ.rs#L1744-L1762

Last updated: Dec 23 2024 at 12:05 UTC