Stream: git-wasmtime

Topic: wasmtime / issue #6446 Implement preview1 rights handling...

Wasmtime GitHub notifications bot (May 24 2023 at 14:52):

rvolosatovs opened issue #6446:

Feature

Both standalone preview1 adapter and the "embedded" preview1->preview2 translation layer should implement preview1 rights handling.
Refs https://github.com/bytecodealliance/wasmtime/pull/6440#discussion_r1202991271
Refs https://github.com/bytecodealliance/wasmtime/issues/6370

Benefit

Full preview1 functionality without breaking users and/or panicking at runtime

Implementation

Mimic what preview1 already does and implement fd_fdstat_set_rights in both adapters

Alternatives

None really IMO

Wasmtime GitHub notifications bot (May 24 2023 at 15:07):

pchickey commented on issue #6446:

We have decided that the rights system is a failed experiment, and I ripped out the support in the legacy code in order to make our test suite consistent across the old and new implementations: https://github.com/bytecodealliance/wasmtime/pull/6265

The adapters should just no-op on the calls to set_rights, and the rights flags are only used to determine the read and write oflags in path_open.

Wasmtime GitHub notifications bot (May 24 2023 at 21:45):

pchickey closed issue #6446:

Feature

Both standalone preview1 adapter and the "embedded" preview1->preview2 translation layer should implement preview1 rights handling.
Refs https://github.com/bytecodealliance/wasmtime/pull/6440#discussion_r1202991271
Refs https://github.com/bytecodealliance/wasmtime/issues/6370

Benefit

Full preview1 functionality without breaking users and/or panicking at runtime

Implementation

Mimic what preview1 already does and implement fd_fdstat_set_rights in both adapters

Alternatives

None really IMO

Last updated: Nov 22 2024 at 17:03 UTC