Stream: git-wasmtime

Topic: wasmtime / issue #6438 Use `GITHUB_TOKEN` in install script


view this post on Zulip Wasmtime GitHub notifications bot (May 23 2023 at 11:44):

gbryant-arm opened issue #6438:

Feature

Improve support for Github workflows by using GITHUB_TOKEN in the install script (https://wasmtime.dev/install.sh) to increase the REST API's rate limit

Benefit

To get the latest version, the install script sends an unauthenticated request to Github's REST API, which is subject to a rate limit of 60 requests per hour.
Using GITHUB_TOKEN in Github workflows would push that limit to 1000 requests per hour

Implementation

See https://docs.github.com/en/actions/security-guides/automatic-token-authentication#example-2-calling-the-rest-api

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2024 at 10:35):

rikhuijzer commented on issue #6438:

I think this is fixed if you use bytecodealliance/actions/wasmtime/setup from https://github.com/bytecodealliance/actions. That project uses the default GitHub Action token: https://github.com/bytecodealliance/actions/commit/d0325fe0b8ce57a326793bb0ea98695a2ef20db7.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2024 at 15:17):

alexcrichton closed issue #6438:

Feature

Improve support for Github workflows by using GITHUB_TOKEN in the install script (https://wasmtime.dev/install.sh) to increase the REST API's rate limit

Benefit

To get the latest version, the install script sends an unauthenticated request to Github's REST API, which is subject to a rate limit of 60 requests per hour.
Using GITHUB_TOKEN in Github workflows would push that limit to 1000 requests per hour

Implementation

See https://docs.github.com/en/actions/security-guides/automatic-token-authentication#example-2-calling-the-rest-api

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2024 at 15:17):

alexcrichton commented on issue #6438:

Ah yes good point! I'd recommend the same nowadays to install wasmtime in CI, so I'll close this.


Last updated: Nov 22 2024 at 16:03 UTC