Wasmtime GitHub notifications bot (May 17 2023 at 18:44): Wasmtime GitHub notifications bot (May 17 2023 at 18:44):github-actions[bot] commented on issue #6400:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 17 2023 at 19:00):alexcrichton commented on issue #6400:
I think that failure may be a bug with github's merge queue...
Wasmtime GitHub notifications bot (May 17 2023 at 19:01):saulecabrera commented on issue #6400:
Oh that makes sense; I was taking a look to see if it was a failure due my changes, but all jobs were marked as cancelled.
Wasmtime GitHub notifications bot (May 17 2023 at 19:30):alexcrichton commented on issue #6400:
It's a bit odd but I think that one is legitimate. I think MSVC failed there with 127, which may mean that there's something Windows-specific about the failure.
Wasmtime GitHub notifications bot (May 17 2023 at 19:44):saulecabrera commented on issue #6400:
Yep, I see it; I'll take a look!
Wasmtime GitHub notifications bot (May 22 2023 at 12:37):saulecabrera commented on issue #6400:
I spent some time debugging this issue and it's indeed legitimate. The root cause of the failure in MSVC is the lack of unwind info, which as far as I understand is required in Windows; I can reproduce the exact same failure by disabling the unwind info generation in Cranelift. I'm working on a separate PR to add support for emitting unwind info in Winch.
Wasmtime GitHub notifications bot (May 22 2023 at 14:19):alexcrichton commented on issue #6400:
Ah that sounds familiar! If you want to add
#[cfg_attr(windows, ignore)]now for those tests with a comment I think that'd be sufficient.
Wasmtime GitHub notifications bot (May 22 2023 at 18:44):saulecabrera commented on issue #6400:
Sounds good, yeah, I'll ignore them to land this PR and put them back when introducing support for the emitting unwind info.
Wasmtime GitHub notifications bot (May 22 2023 at 18:46):saulecabrera edited a comment on issue #6400:
Sounds good, yeah, I'll ignore them to land this PR and put them back once I introduce support for emitting the unwind information.
Last updated: Oct 23 2024 at 20:03 UTC