Stream: git-wasmtime

Topic: wasmtime / issue #6391 Land preview2-prototyping's Wasi P...

Wasmtime GitHub notifications bot (May 18 2023 at 20:31):

pchickey commented on issue #6391:

That's correct: The new implementation is totally separate from the old one. There are a number of known deficiencies with the new implementation but we decided its time to move to this and iterate here. The new implementation won't replace the old one until we have resolved all of those problems, and it passes all of the same tests.

The comment in file_dir_sync.rs is a @sunfishcode question - I don't actually know what that means.

Wasmtime GitHub notifications bot (May 18 2023 at 20:42):

sunfishcode commented on issue #6391:

I think that comment in file_dir_sync.rs is outdated. I think we can uncomment those two lines.

Windows doesn't have a way to do a sync on a directory handle. Originally, WASI's impl would fail on Windows because we'd try to call the Windows API for files and it would fail when passed a directory handle. Now, we handle this so that it silently does nothing, which is the direction I think WASI as a whole is heading. The semantics for sync are "do whatever sync means in the underlying fs", and on Windows, that means do nothing.

Last updated: Nov 22 2024 at 16:03 UTC