Wasmtime GitHub notifications bot (May 16 2023 at 21:23): Wasmtime GitHub notifications bot (May 16 2023 at 21:23):alexcrichton commented on issue #6390:
I'll note that I'm opening this as a draft as I'm working my way up the stack. My goal is to prove out https://github.com/bytecodealliance/wasm-tools/pull/1027 and once everything is ready have a day I spend landing the various changes.
Wasmtime GitHub notifications bot (May 25 2023 at 21:10):alexcrichton commented on issue #6390:
Ok I've now updated this for the final set of merged changes to wasm-tools, which aren't yet published. The major changes in this PR are now:
- All wasm-tools deps are updated (currently sitting at git deps to my "bump" branch)
- WIT syntax is changing, as well as the binary format of components
- All WIT files vendored in this repository are updated to the new syntax. Notably the wasi-http WITs are not updated because they're a submodule. This means that all wasi-http-related tests and support are disabled.
- There is now only one copy of WIT for WASI, and all other duplicate copies are deleted.
- All of the preview2 implementation has been updated for the new hierarchy of modules created by
wasmtime::component::bindgen!One interesting aspect of this is that there's a temporary git dependency on wit-bindgen. I'm not actually sure how to get rid of that because the adapter requires wit-bindgen and it's not easy to remove that. This is somewhat ok though since we don't publish anything with wit-bindgen so I'm hoping it's ok to have a temporary state of affairs with a git dep here before I can go use this PR to update wit-bindgen to make a release there.
Wasmtime GitHub notifications bot (May 25 2023 at 21:23):alexcrichton commented on issue #6390:
cc @rvolosatovs and @sunfishcode as y'all are likely interested in the various changes here too
Wasmtime GitHub notifications bot (May 31 2023 at 14:49):rvolosatovs commented on issue #6390:
Seems like a component using latest WIT interfaces generated with
wit-component 0.11.0fails to compile with:0: failed to parse WebAssembly module 1: unsupported component version: 0xc (at offset 0x0)Originating somewhere in https://github.com/bytecodealliance/wasmtime/blob/c044790a9047db1593516b9c6916642c155ee87a/crates/environ/src/component/translate.rs#L328-L377
Wasmtime GitHub notifications bot (May 31 2023 at 14:50):rvolosatovs edited a comment on issue #6390:
Seems like a component using latest WIT interfaces generated with
wit-component 0.11.0fails to compile with:0: failed to parse WebAssembly module 1: unsupported component version: 0xc (at offset 0x0)Originating somewhere in https://github.com/bytecodealliance/wasmtime/blob/c044790a9047db1593516b9c6916642c155ee87a/crates/environ/src/component/translate.rs#L328-L377
Wasmtime GitHub notifications bot (May 31 2023 at 14:51):alexcrichton commented on issue #6390:
Can you confirm that
wit-component0.11.0 was used? The version0xcis the "old" version of components and the upgraded versions should be0xd, so it may be the case thatwit-component 0.11.0wasn't used by accident?
Wasmtime GitHub notifications bot (May 31 2023 at 14:58):rvolosatovs commented on issue #6390:
Can you confirm that
wit-component0.11.0 was used? The version0xcis the "old" version of components and the upgraded versions should be0xd, so it may be the case thatwit-component 0.11.0wasn't used by accident?I'll try to minimize this later today
Wasmtime GitHub notifications bot (May 31 2023 at 17:52):rvolosatovs commented on issue #6390:
Can you confirm that
wit-component0.11.0 was used? The version0xcis the "old" version of components and the upgraded versions should be0xd, so it may be the case thatwit-component 0.11.0wasn't used by accident?false alarm, it was an outdated transitive dependency. Can confirm that everything works as expected. Thanks for prompt response!
Last updated: Oct 23 2024 at 20:03 UTC