Stream: git-wasmtime

Topic: wasmtime / issue #6384 aarch64: Fix Ldr19 relocations bei...

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 01:44):

cfallin commented on issue #6384:

(Assigning myself -- talked with Alex earlier today and happy to take this one)

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 02:04):

github-actions[bot] commented on issue #6384:

Subscribe to Label Action

cc @fitzgen, @peterhuene, @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "cranelift:meta", "cranelift:module", "fuzzing", "wasmtime:api", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 11:19):

afonso360 commented on issue #6384:

Hey, I was playing around with adding this setting to fuzzgen and it found a panic on AArch64, looks like when setting bb_padding_log2 to 1, (I suspect) we get an unaligned basic block, which causes issues.

<details>

<summary>Testcase</summary>

test compile
set bb_padding_log2=1
target aarch64

function u1:0(i64) -> i64{
block0(v0: i64):
    jump block1

block1:
    return v0
}

Panic:

thread 'worker #0' panicked at 'assertion failed: pc_rel & 3 == 0', cranelift/codegen/src/isa/aarch64/inst/mod.rs:2847:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: assertion failed: pc_rel & 3 == 0
FAIL ./lmao.clif: panicked in worker #0: assertion failed: pc_rel & 3 == 0
1 tests
Error: 1 failure

</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 14:13):

alexcrichton commented on issue #6384:

we get an unaligned basic block, which causes issues.

Indeed! Fuzzing for me locally turned that up quite quickly and I forgot to push that up last night. I added a re-alignment now to get past that. Fuzzing found another panic last night so I'm going to debug that before merging this.

Last updated: Dec 23 2024 at 12:05 UTC