Stream: git-wasmtime

Topic: wasmtime / issue #6374 Land preview2-prototying's wasi-pr...

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 22:32):

pchickey commented on issue #6374:

This PR is too big contains too many commits for prtest:full to work properly, so I temporarily removed the if test-full predicate in https://github.com/bytecodealliance/wasmtime/pull/6374/commits/bb5d051584658f24b5a3caa403726b619fb1257a and restored it in https://github.com/bytecodealliance/wasmtime/pull/6374/commits/968a61dbc402fbfc429353f9b4d30b479d1fa556

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 18:13):

pchickey commented on issue #6374:

Feedback is taken care of, and collapsing it into one workspace brought a bunch of cargo vet stuff into scope, so that is now taken care of as well.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 19:25):

alexcrichton commented on issue #6374:

This failed on CI, but additionally I think we'll want to temporarily set the merge strategy for the merge queue to creating a merge commit for merging this instead of the current squash-and-merge strategy

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 19:53):

pchickey commented on issue #6374:

oof, good catch. After all that work to preserve the git history I almost goofed the squash commit.

Last updated: Oct 23 2024 at 20:03 UTC