Stream: git-wasmtime

Topic: wasmtime / issue #6358 winch: Implement new trampolines

view this post on Zulip Wasmtime GitHub notifications bot (May 09 2023 at 13:46):

github-actions[bot] commented on issue #6358:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 09 2023 at 15:01):

alexcrichton commented on issue #6358:

Random thought about pinned registers -- while this isn't a problem for winch yet the final set of trampolines are the libcall trampolines which enter the runtime for instructions like memory.grow. These trampolines are still handwritten asm and don't come from Cranelift, and they don't handle anything about pinned registers and such at this time. Not to say they couldn't, just something to keep in mind.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 20:37):

saulecabrera commented on issue #6358:

@alexcrichton I've addressed all of your comments; I think this is ready for another pass. I've opted to leave the translation between ptr_size <> ValType as a TODO for now.

Regarding your other comments, I've introduced wasmtime-environ as a dependency to winch-codegen as discussed during our last meeting, which allows for a direct usage of VMOffsets and FooIndex types across trampolines. After this PR lands, I'll update the other pre-existing code that uses winch_environ::FuncEnv.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 20:39):

saulecabrera edited a comment on issue #6358:

@alexcrichton I've addressed all of your comments; I think this is ready for another pass. I've opted to leave the translation between ptr_size <> ValType as a TODO for now.

Regarding your other comments, I've introduced wasmtime-environ as a dependency to winch-codegen as discussed during our last meeting, which allows for a direct usage of VMOffsets and FooIndex types across trampolines. After this PR lands, I'll update the other pre-existing code that uses winch_environ::FuncEnv.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 21:05):

saulecabrera commented on issue #6358:

I'm not exactly sure why the MIRI check is failing.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 13:08):

saulecabrera commented on issue #6358:

I'm not exactly sure why the MIRI check is failing.

I realized that all the other tests are ignoring miri, so I applied the same attribute to Winch's tests.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 16:19):

saulecabrera commented on issue #6358:

Agreed; @cfallin, added you as a reviewer, let me know if you have any thoughts!

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 16:23):

saulecabrera edited a comment on issue #6358:

Agreed; @cfallin, re-added you as a reviewer, let me know if you have any thoughts!

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 17:15):

cfallin commented on issue #6358:

Agreed; @cfallin, re-added you as a reviewer, let me know if you have any thoughts!

Yep, I'll take a look now!

Last updated: Dec 23 2024 at 13:07 UTC