Stream: git-wasmtime

Topic: wasmtime / issue #6279 x64: Add non-SSE4.1 lowerings of `...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2023 at 17:43):

abrown commented on issue #6279:

Also, just a general thought: how can we check that fuzzing is using all of these new <SSE4.1 lowerings?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2023 at 01:43):

alexcrichton commented on issue #6279:

Currently there's no fuzz coverage due to this but at the end of this road I'll be able to disable that meaning we'll get fuzz coverage.

Once that's removed though we should get fuzz coverage. For example after https://github.com/bytecodealliance/wasmtime/pull/6206 the pcmpgtq instruction is now conditional. Looking at yesterday's coverage report I found the coverage of the ISLE-generated file and inside of constructor_x64_pcmpgt I see x64_pcmpgtq is called 317 times with the fallback being called 7 times (direct link). Not a huge number of executions but still there!

Last updated: Nov 22 2024 at 16:03 UTC