Stream: git-wasmtime

Topic: wasmtime / issue #6246 riscv64: Remove the gen_move2 helper

Wasmtime GitHub notifications bot (Apr 19 2023 at 18:53):

elliottt commented on issue #6246:

I'm curious whether the gen_move helper is still necessary too, but at a quick glance the five existing uses look plausibly like they might be important.

I was wondering the same thing. We'd need to preserve the cases where the move changes the register class, but other than that we could probably turn it into a no-op. Refactoring it so that it returned the destination would help here, though that function might also be used in the emit code, which complicates things a bit.

Wasmtime GitHub notifications bot (Apr 19 2023 at 19:05):

jameysharp commented on issue #6246:

There's Inst::gen_move which is used in emit.rs, but I believe that's entirely unrelated to the gen_move in inst/mod.rs. So I think we're in good shape there.

Last updated: Dec 23 2024 at 12:05 UTC