Stream: git-wasmtime

Topic: wasmtime / issue #6228 Make streams owned by request/resp...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 18 2023 at 04:15):

brendandburns commented on issue #6228:

cc @pchickey

view this post on Zulip Wasmtime GitHub notifications bot (Apr 18 2023 at 15:22):

brendandburns commented on issue #6228:

fwiw, looks like tests failed b/c of a network failure pulling the wasi-http submodule.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 18 2023 at 17:54):

pchickey commented on issue #6228:

I hit rerun and now it got to a test failure

view this post on Zulip Wasmtime GitHub notifications bot (Apr 18 2023 at 18:28):

alexcrichton commented on issue #6228:

I'm going to move this to @pchickey's review queue as he's more familiar with the implementation than I

view this post on Zulip Wasmtime GitHub notifications bot (Apr 19 2023 at 22:12):

brendandburns commented on issue #6228:

Comments generally addressed, couple where I need some more feedback.

Please take another look.

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2023 at 17:00):

brendandburns commented on issue #6228:

I'm not sure I follow your question. Are you asking why we don't use BytesMut instead of a Bytes in the Stream struct? We could do that if we wanted to, I'm not sure it actually matters that much because we'd need to turn it back into a single contiguous array of bytes at some point, but it might be more efficient.

Let me know if that's the change you are suggesting, or if I'm missing something.

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2023 at 18:07):

pchickey commented on issue #6228:

@brendandburns I can merge this when ready, please ping when the above discussion is resolved.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2023 at 23:00):

brendandburns commented on issue #6228:

@pchickey I think this is ready to merge.

Last updated: Oct 23 2024 at 20:03 UTC