brendandburns commented on issue #6228:
cc @pchickey
brendandburns commented on issue #6228:
fwiw, looks like tests failed b/c of a network failure pulling the
wasi-http
submodule.
pchickey commented on issue #6228:
I hit rerun and now it got to a test failure
alexcrichton commented on issue #6228:
I'm going to move this to @pchickey's review queue as he's more familiar with the implementation than I
brendandburns commented on issue #6228:
Comments generally addressed, couple where I need some more feedback.
Please take another look.
Thanks!
brendandburns commented on issue #6228:
I'm not sure I follow your question. Are you asking why we don't use
BytesMut
instead of aBytes
in theStream
struct? We could do that if we wanted to, I'm not sure it actually matters that much because we'd need to turn it back into a single contiguous array of bytes at some point, but it might be more efficient.Let me know if that's the change you are suggesting, or if I'm missing something.
Thanks!
pchickey commented on issue #6228:
@brendandburns I can merge this when ready, please ping when the above discussion is resolved.
brendandburns commented on issue #6228:
@pchickey I think this is ready to merge.
Last updated: Dec 23 2024 at 12:05 UTC