Wasmtime GitHub notifications bot (Apr 12 2023 at 17:11): Wasmtime GitHub notifications bot (Apr 12 2023 at 17:11):Kmeakin commented on issue #6196:
https://github.com/bytecodealliance/wasmtime/pull/6140 has been merged, so the first 2 commits can be removed
Wasmtime GitHub notifications bot (Apr 13 2023 at 13:13):afonso360 commented on issue #6196:
That is a really neat way of decomposing this op @jameysharp, Thanks! And thank you everyone for proving this works!
I've added some comments that hopefully explain the new rule in a way that makes sense to anyone reading, but it's a lot simpler now.
Wasmtime GitHub notifications bot (Apr 14 2023 at 18:50):jameysharp commented on issue #6196:
The /bench_x64 thing didn't run but I've just run a few Sightglass benchmarks on this locally. On bz2, pulldown-cmark, and spidermonkey, there's no significant difference between this PR at e1d2f515b and main at 2d25db047, except in compilation speed, where this PR seems to be faster (by <1%) for no obvious reason. (There are a few extra commits on the version of
mainthat I compared against, so it's possible one of those slowed compilation down.)I'm going ahead and merging this. These are good rewrites even if they don't happen to help these particular benchmarks, after all.
Last updated: Oct 23 2024 at 20:03 UTC