Stream: git-wasmtime

Topic: wasmtime / issue #6175 Removes debug assertion that was r...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 19:28):

fitzgen commented on issue #6175:

I don't think #796 is what you mean?

And I think this might effectively be a duplicate of https://github.com/bytecodealliance/wasmtime/pull/5553?

In any case, we don't want to simply remove assertions, we want to fix the underlying reason the assertion is failing. Therefore, we won't want to merge this PR in its current state.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 20:03):

bjorn3 commented on issue #6175:

It is issue 796 on the old cranelift repo before cranelift was merged into the wasmtime repo.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 20:42):

kevaundray commented on issue #6175:

Happy to close, though maybe it's better to update the issue number on the PR?

Last updated: Dec 23 2024 at 12:05 UTC