Stream: git-wasmtime

Topic: wasmtime / issue #6171 Update several dependencies.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2023 at 20:44):

github-actions[bot] commented on issue #6171:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 18:19):

sunfishcode commented on issue #6171:

This apparenetly failed in the merge queue in the "Record the result of testing and building steps" step, but there's no indication of what the problem is.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 19:27):

alexcrichton commented on issue #6171:

The error isn't always apparent due to various reasons, but if you look through the logs this is the error:

error[E0599]: no method named `is_null` found for type `isize` in the current scope
   --> crates\runtime\src\mmap.rs:143:24
    |
143 |                 if ptr.is_null() {
    |                        ^^^^^^^ method not found in `isize`

error[E0308]: mismatched types
   --> crates\runtime\src\mmap.rs:495:50
    |
495 |                 let r = unsafe { UnmapViewOfFile(self.ptr as *mut c_void) };
    |                                  --------------- ^^^^^^^^^^^^^^^^^^^^^^^ expected `isize`, found `*mut c_void`
    |                                  |
    |                                  arguments to this function are incorrect
    |
    = note:     expected type `isize`
            found raw pointer `*mut c_void`
note: function defined here
   --> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\windows-sys-0.48.0\src\Windows\Win32\System\Memory\mod.rs:159:137
    |
159 | ...s: `\"Win32_System_Memory\"`, `\"Win32_Foundation\"`*"] fn UnmapViewOfFile ( lpbaseaddress : MEMORYMAPPEDVIEW_HANDLE ) -> super::super...
    |                                                               ^^^^^^^^^^^^^^^

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 22:45):

sunfishcode commented on issue #6171:

Thanks. I've now fixed that error.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 14:54):

alexcrichton commented on issue #6171:

I think that's a minor windows error:

error[E0432]: unresolved import `windows_sys::Win32::Foundation::HINSTANCE`
   --> cranelift\jit\src\backend.rs:934:9
    |
934 |     use windows_sys::Win32::Foundation::HINSTANCE;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `HINSTANCE` in `Windows::Win32::Foundation`

Last updated: Nov 22 2024 at 16:03 UTC