Wasmtime GitHub notifications bot (Apr 06 2023 at 00:05): Wasmtime GitHub notifications bot (Apr 06 2023 at 00:05):brendandburns commented on issue #6161:
fwiw, the test failed b/c there was a
502error from postman-echo.com. We may want to turn up a localhost server instead to reduce flakiness.
Wasmtime GitHub notifications bot (Apr 06 2023 at 18:08):cfallin commented on issue #6161:
fwiw, the test failed b/c there was a
502error from postman-echo.com. We may want to turn up a localhost server instead to reduce flakiness.I'd strongly +1 this: I was confused just now watching CI logs and seeing queries to an external website. We definitely should not have dependencies on a third-party service like this in our core CI flows, especially given that we will sometimes have time-sensitive CI builds (e.g. for security issues) that cannot tolerate third-party downtime.
Wasmtime GitHub notifications bot (Apr 06 2023 at 18:35):pchickey commented on issue #6161:
Agreed, this is one of the things i thought was OK for an initial prototype but we should remedy pretty quickly.
In addition to having integration tests that run against local webservers, we can also pursue writing tests by abstracting over how hyper forms connections, and connect to hyper services in the same process, skipping syscalls entirely. We would still want some tests to connect on a "real" local network to make sure that code gets exercised as well.
Wasmtime GitHub notifications bot (Apr 06 2023 at 22:08):brendandburns commented on issue #6161:
I will update the tests in this PR to run against
localhost
Last updated: Dec 23 2024 at 12:05 UTC