Stream: git-wasmtime

Topic: wasmtime / issue #6144 ISLE: pattern type is always known

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 01:03):

github-actions[bot] commented on issue #6144:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2023 at 14:35):

seanjensengrey commented on issue #6144:

@jameysharp could this be a viable clippy lint?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2023 at 15:19):

jameysharp commented on issue #6144:

I don't know how much a Clippy lint can do. This PR required checking every call site for translate_pattern to see that a particular argument either used the same enum variant or was a recursive call that passed that argument through unchanged. Does Clippy do inter-procedural analyses like that?

It helped that the method in question was not pub so it was easy to prove I'd checked all of its possible call sites. In general, I'd guess a Clippy lint for this couldn't fire all that often since any functions visible outside the crate would have to be exempt.

At any rate, I think this is a question you should pose to the Clippy developers. We generally don't use Clippy in this project so I'm not all that familiar with it. But it's an interesting question and I do like to indulge in a good static analysis on occasion.

Last updated: Oct 23 2024 at 20:03 UTC