Stream: git-wasmtime

Topic: wasmtime / issue #6140 ISLE: split algebraic.isle into se...

Wasmtime GitHub notifications bot (Apr 04 2023 at 18:04):

jameysharp commented on issue #6140:

It's definitely a good idea to split up these rules, and I like the division you've chosen between operations. But I think you probably intended to delete cranelift/filetests/filetests/egraph/algebraic.clif too, right?

Wasmtime GitHub notifications bot (Apr 05 2023 at 13:47):

Kmeakin commented on issue #6140:

It's definitely a good idea to split up these rules, and I like the division you've chosen between operations. But I think you probably intended to delete cranelift/filetests/filetests/egraph/algebraic.clif too, right?

Yes, that should have been removed

Wasmtime GitHub notifications bot (Apr 07 2023 at 00:49):

Kmeakin commented on issue #6140:

I see that algebraic.clif is still not deleted though, and I've made one other request below. Could you take care of those? I'd be happy to merge this on Monday.

I have deleted algebraic.clif several times now, very confused

Last updated: Oct 23 2024 at 20:03 UTC