Stream: git-wasmtime

Topic: wasmtime / issue #6131 Make cranelift-codegen actually no...

Wasmtime GitHub notifications bot (Apr 01 2023 at 07:36):

cfallin commented on issue #6131:

@ondra05 thank you for the PR! Unfortunately, we currently have a policy on no_std (that's for Wasmtime but Cranelift aligns with this for now too). The basic argument that has been raised is that while a one-off "fix no_std" PR may or may not be that bad, the ongoing cost in (i) CI time, (ii) small papercuts for new contributors is maybe not worth the benefit of additional use-cases.

That said, at least part of that policy is more applicable to Wasmtime than Cranelift (specifically the dependence on OS primitives -- a compiler needs far fewer) and IMHO at least, we shouldn't be too dogmatic with policy when the stakes are fairly low (as here), and given that Cranelift once did support this. If you want to drive this forward, one thing you could do is attend our Cranelift weekly meeting and raise the topic, and we can see how others feel. A data point to answer "how much CI time does a cargo check for no_std on cranelift-codegen add" would be useful too, if you want to make the argument, as would be examples of use-cases (we might consider additional use-cases a good reason to do something if they bring users and grow the community of potential contributors more than the required features add in support cost).

Wasmtime GitHub notifications bot (Apr 03 2023 at 15:57):

jameysharp commented on issue #6131:

To say what Chris said another way: Please tell us why you want no_std support in Cranelift, because that will help us understand what we should be doing to help. (And also because we're always curious about how people are using Cranelift!)

I think the fact that the remaining issues are all in our pass-timing module is significant. That's obviously not necessary for using Cranelift. (It's also probably pretty useless in a no_std environment.) And I think a no-op implementation shouldn't be too invasive. So I think a Cargo feature for enabling pass-timing would be a reasonable change, even if we didn't want to support no_std. I would ask for that as a separate PR though so we can review it without thinking about other no_std changes at the same time.

Wasmtime GitHub notifications bot (May 23 2023 at 00:38):

coffeebe4code commented on issue #6131:

Does having the core implementations impact the final size of cranelift? If smaller, that could be a benefit. Another benefit is if someone were working on an OS that was custom built, they might use no_std.

Last updated: Nov 22 2024 at 16:03 UTC