Stream: git-wasmtime

Topic: wasmtime / issue #6120 ISLE: move `icmp` rewrites to sepa...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 23:58):

cfallin commented on issue #6120:

Taking a look!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 16:51):

cfallin commented on issue #6120:

@Kmeakin it looks like this is still not quite a verbatim move, which is making it tricky for me to verify -- e.g., this rule

;; Optimize icmp-of-icmp.
(rule (simplify (ne ty
                      (uextend _ inner @ (icmp ty _ _ _))
                      (iconst _ (u64_from_imm64 0))))
      (subsume inner))

became

;; Optimize icmp-of-icmp:
(rule (simplify (ne ty (uextend _ inner @ (icmp ty _ _ _)) (iconst _ (u64_from_imm64 0))))
      (subsume inner))

I'm trying not to be too picky but I also find it much easier if code motion isn't mixed in with re-formatting, change of comments, etc.; if you don't mind, would you be able to redo the code-motion with a straight copy-paste, keeping things in the same order, then we can do other refactors later?

Last updated: Nov 22 2024 at 16:03 UTC