Wasmtime GitHub notifications bot (Mar 20 2023 at 14:47): Wasmtime GitHub notifications bot (Mar 20 2023 at 14:47):saulecabrera commented on issue #6067:
Oh It seems I messed up the branches and that's why https://github.com/bytecodealliance/wasmtime/pull/6067/commits/03637c95fa75767a9c4cfedd638cb1f45016053d which is unrelated to this change appears. I'll fix that.
Wasmtime GitHub notifications bot (Mar 20 2023 at 14:58):saulecabrera edited a comment on issue #6067:
Oh It seems I messed up the branches and that's why https://github.com/bytecodealliance/wasmtime/pull/6067/commits/03637c95fa75767a9c4cfedd638cb1f45016053d which is unrelated to this change appears. I'll mark it as draft while I fix that.
Wasmtime GitHub notifications bot (Mar 20 2023 at 14:59):saulecabrera edited a comment on issue #6067:
Oh It seems I messed up the branches and that's why https://github.com/bytecodealliance/wasmtime/pull/6067/commits/03637c95fa75767a9c4cfedd638cb1f45016053d which is unrelated to this change appears. I'll fix that.
Wasmtime GitHub notifications bot (Mar 20 2023 at 15:15):saulecabrera commented on issue #6067:
It's now fixed!
Wasmtime GitHub notifications bot (Mar 20 2023 at 17:44):github-actions[bot] commented on issue #6067:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 27 2023 at 23:01):saulecabrera commented on issue #6067:
@cfallin thanks for the review and sorry it took me a bit to get back to this.
Good call on introducing a more complex test -- I was able to uncover a bug regarding addresses in the spill behaviour. I've introduced a fix and an explanation in https://github.com/bytecodealliance/wasmtime/pull/6067/commits/5e058d21165477cd4ae1d1257c7f7f218d604f50. Given that I introduced some new changes, I'd appreciate if you could take another look. Thanks!
Last updated: Oct 23 2024 at 20:03 UTC