Stream: git-wasmtime

Topic: wasmtime / issue #6055 Cranelift: Consider taking `trapnz...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2023 at 19:33):

fitzgen opened issue #6055:

Right now we legalize them into a conditional jump to a cold block with a trap intruction early on in the pipeline.

But every backend already has some variant of MInst.TrapIf, which is the same as trapnz, so it would be easy to support in lowering if we wanted to move it there.

Benefits:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2023 at 19:33):

fitzgen labeled issue #6055:

Right now we legalize them into a conditional jump to a cold block with a trap intruction early on in the pipeline.

But every backend already has some variant of MInst.TrapIf, which is the same as trapnz, so it would be easy to support in lowering if we wanted to move it there.

Benefits:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2023 at 19:33):

fitzgen labeled issue #6055:

Right now we legalize them into a conditional jump to a cold block with a trap intruction early on in the pipeline.

But every backend already has some variant of MInst.TrapIf, which is the same as trapnz, so it would be easy to support in lowering if we wanted to move it there.

Benefits:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2023 at 19:34):

github-actions[bot] commented on issue #6055:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 21:57):

fitzgen closed issue #6055:

Right now we legalize them into a conditional jump to a cold block with a trap intruction early on in the pipeline.

But every backend already has some variant of MInst.TrapIf, which is the same as trapnz, so it would be easy to support in lowering if we wanted to move it there.

Benefits:

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 21:57):

fitzgen commented on issue #6055:

Fixed in #0972


Last updated: Dec 23 2024 at 12:05 UTC