Stream: git-wasmtime

Topic: wasmtime / issue #6049 Port divide-by-constant magic numb...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2023 at 17:46):

fitzgen opened issue #6049:

This is the old simple preopt stuff for some number divided/remaindered by a non-power-of-two constant:

The ISLE + e-graphs mid-end work replaced simple_preopt, but never ported these magic constants over. We should port them over.

HOWEVER, right now we can't replace potentially-trapping instructions in ISLE, and we need that ability to do this.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2023 at 17:46):

fitzgen labeled issue #6049:

This is the old simple preopt stuff for some number divided/remaindered by a non-power-of-two constant:

The ISLE + e-graphs mid-end work replaced simple_preopt, but never ported these magic constants over. We should port them over.

HOWEVER, right now we can't replace potentially-trapping instructions in ISLE, and we need that ability to do this.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2023 at 17:46):

fitzgen labeled issue #6049:

This is the old simple preopt stuff for some number divided/remaindered by a non-power-of-two constant:

The ISLE + e-graphs mid-end work replaced simple_preopt, but never ported these magic constants over. We should port them over.

HOWEVER, right now we can't replace potentially-trapping instructions in ISLE, and we need that ability to do this.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2023 at 17:46):

github-actions[bot] commented on issue #6049:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2023 at 22:49):

jameysharp commented on issue #6049:

Specifically, this depends on #5908.


Last updated: Nov 22 2024 at 17:03 UTC