Wasmtime GitHub notifications bot (Mar 17 2023 at 01:13): Wasmtime GitHub notifications bot (Mar 17 2023 at 01:13):Kmeakin commented on issue #6037:
These all look correct to me -- thanks!
I'll note a stylistic thought (but I don't think any change is needed): I noticed the
@-bindings in the left-hand sides are sometimes unused; I assume the intent of e.g.umin @ ...is to document the value at a glance? I do actually like that, but just wanted to call it out and my interpretation of it in case anyone else has thoughts. It's not an idiom I've seen before in our rules.Yes, the unused
umin @ ...is for documentation. I can delete them if you prefer
Wasmtime GitHub notifications bot (Mar 17 2023 at 18:54):cfallin commented on issue #6037:
No, I like the variable-bindings-as-documentation pattern actually; this LGTM. Thanks!
Last updated: Dec 23 2024 at 12:05 UTC