Stream: git-wasmtime

Topic: wasmtime / issue #5989 Cranelift: AArch64 `attempt to add...

Wasmtime GitHub notifications bot (Mar 11 2023 at 11:37):

afonso360 opened issue #5989:

:wave: Hey,

.clif Test Case

test compile
target aarch64

function %a() -> i8x16 system_v {
    const0 = 0x00000000000000000000000000000000

block0:
    v8 = vconst.i8x16 const0
    v17 = shuffle v8, v8, 0x00f2009e32ddd6465503ffffffffffff  ; v8 = const0, v8 = const0
    return v17
}

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The test to pass.

Actual Results

     Running `/home/afonso/git/qemu/qemu-7.2.0/build/qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'attempt to add with overflow', cranelift/codegen/src/isa/aarch64/lower/isle.rs:749:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: attempt to add with overflow
FAIL ./lmao.clif: panicked in worker #0: attempt to add with overflow
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: AArch64

Extra Info

The panic happens here and seems to have been introduced in #5977. (cc @alexcrichton)

Wasmtime GitHub notifications bot (Mar 11 2023 at 11:37):

afonso360 labeled issue #5989:

:wave: Hey,

.clif Test Case

test compile
target aarch64

function %a() -> i8x16 system_v {
    const0 = 0x00000000000000000000000000000000

block0:
    v8 = vconst.i8x16 const0
    v17 = shuffle v8, v8, 0x00f2009e32ddd6465503ffffffffffff  ; v8 = const0, v8 = const0
    return v17
}

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The test to pass.

Actual Results

     Running `/home/afonso/git/qemu/qemu-7.2.0/build/qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'attempt to add with overflow', cranelift/codegen/src/isa/aarch64/lower/isle.rs:749:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: attempt to add with overflow
FAIL ./lmao.clif: panicked in worker #0: attempt to add with overflow
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: AArch64

Extra Info

The panic happens here and seems to have been introduced in #5977. (cc @alexcrichton)

Wasmtime GitHub notifications bot (Mar 11 2023 at 11:37):

afonso360 labeled issue #5989:

:wave: Hey,

.clif Test Case

test compile
target aarch64

function %a() -> i8x16 system_v {
    const0 = 0x00000000000000000000000000000000

block0:
    v8 = vconst.i8x16 const0
    v17 = shuffle v8, v8, 0x00f2009e32ddd6465503ffffffffffff  ; v8 = const0, v8 = const0
    return v17
}

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The test to pass.

Actual Results

     Running `/home/afonso/git/qemu/qemu-7.2.0/build/qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'attempt to add with overflow', cranelift/codegen/src/isa/aarch64/lower/isle.rs:749:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: attempt to add with overflow
FAIL ./lmao.clif: panicked in worker #0: attempt to add with overflow
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: AArch64

Extra Info

The panic happens here and seems to have been introduced in #5977. (cc @alexcrichton)

Wasmtime GitHub notifications bot (Mar 11 2023 at 11:37):

afonso360 labeled issue #5989:

:wave: Hey,

.clif Test Case

test compile
target aarch64

function %a() -> i8x16 system_v {
    const0 = 0x00000000000000000000000000000000

block0:
    v8 = vconst.i8x16 const0
    v17 = shuffle v8, v8, 0x00f2009e32ddd6465503ffffffffffff  ; v8 = const0, v8 = const0
    return v17
}

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The test to pass.

Actual Results

     Running `/home/afonso/git/qemu/qemu-7.2.0/build/qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'attempt to add with overflow', cranelift/codegen/src/isa/aarch64/lower/isle.rs:749:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: attempt to add with overflow
FAIL ./lmao.clif: panicked in worker #0: attempt to add with overflow
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: AArch64

Extra Info

The panic happens here and seems to have been introduced in #5977. (cc @alexcrichton)

Wasmtime GitHub notifications bot (Mar 11 2023 at 19:02):

alexcrichton commented on issue #5989:

Thanks! I'll propose https://github.com/bytecodealliance/wasmtime/pull/5995 to solve this which doesn't involve changing the backend but instead the semantics of the instruction, but if that's not desired I can additionally got add a .wrapping_add in there.

Wasmtime GitHub notifications bot (Mar 11 2023 at 19:37):

afonso360 commented on issue #5989:

I don't mind either way, It should be fairly easy to update the fuzzer to follow the instruction semantics!

Wasmtime GitHub notifications bot (Mar 13 2023 at 15:04):

alexcrichton closed issue #5989:

:wave: Hey,

.clif Test Case

test compile
target aarch64

function %a() -> i8x16 system_v {
    const0 = 0x00000000000000000000000000000000

block0:
    v8 = vconst.i8x16 const0
    v17 = shuffle v8, v8, 0x00f2009e32ddd6465503ffffffffffff  ; v8 = const0, v8 = const0
    return v17
}

Steps to Reproduce

• clif-util test ./the-above.clif

Expected Results

The test to pass.

Actual Results

     Running `/home/afonso/git/qemu/qemu-7.2.0/build/qemu-aarch64 -L /usr/aarch64-linux-gnu -E LD_LIBRARY_PATH=/usr/aarch64-linux-gnu/lib /home/afonso/git/wasmtime/target/aarch64-unknown-linux-gnu/debug/clif-util test ./lmao.clif`
thread 'worker #0' panicked at 'attempt to add with overflow', cranelift/codegen/src/isa/aarch64/lower/isle.rs:749:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 ERROR cranelift_filetests::concurrent > FAIL: panicked in worker #0: attempt to add with overflow
FAIL ./lmao.clif: panicked in worker #0: attempt to add with overflow
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main

Operating system: Linux

Architecture: AArch64

Extra Info

The panic happens here and seems to have been introduced in #5977. (cc @alexcrichton)

Last updated: Nov 22 2024 at 16:03 UTC