maekawatoshiki commented on issue #5978:
I appreciate your review. I changed some confusing variable names as mentioned.
I'll work on the future works once this is merged.
maekawatoshiki commented on issue #5978:
By the way, I tried Sightglass on my machine (Threadripper 2990wx 32C/64T, 128GiB of RAM).
In almost all the benchmarks there were no difference in performance. Some of the benchmarks like below resulted in a slight improvement.
execution :: cycles :: benchmarks/regex/benchmark.wasm Δ = 9064373.70 ± 5762036.73 (confidence = 99%) develop.so is 1.01x to 1.05x faster than main.so! [264111510 285092855.70 372319110] develop.so [267928200 294157229.40 381290250] main.so compilation :: cycles :: benchmarks/regex/benchmark.wasm Δ = 18947346.90 ± 14552917.60 (confidence = 99%) develop.so is 1.00x to 1.02x faster than main.so! [2006043390 2074687356.60 2244890580] develop.so [2056154250 2093634703.50 2262311550] main.so instantiation :: cycles :: benchmarks/regex/benchmark.wasm No difference in performance. [527580 632001.30 846270] develop.so [533730 646062.00 911580] main.so
maekawatoshiki edited a comment on issue #5978:
By the way, I tried Sightglass on my machine (Threadripper 2990wx 32C/64T, 128GiB of RAM).
In almost all the benchmarks there were no difference in performance. Only few of the benchmarks like below resulted in a slight improvement.
execution :: cycles :: benchmarks/regex/benchmark.wasm Δ = 9064373.70 ± 5762036.73 (confidence = 99%) develop.so is 1.01x to 1.05x faster than main.so! [264111510 285092855.70 372319110] develop.so [267928200 294157229.40 381290250] main.so compilation :: cycles :: benchmarks/regex/benchmark.wasm Δ = 18947346.90 ± 14552917.60 (confidence = 99%) develop.so is 1.00x to 1.02x faster than main.so! [2006043390 2074687356.60 2244890580] develop.so [2056154250 2093634703.50 2262311550] main.so instantiation :: cycles :: benchmarks/regex/benchmark.wasm No difference in performance. [527580 632001.30 846270] develop.so [533730 646062.00 911580] main.so
Last updated: Nov 22 2024 at 16:03 UTC